Fix and modify requires behavior. #1677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further to the change in behaviour, please see the results of this experiment where the templating system is considering a zero length string as "not set". version: "3"
vars:
A: fubar
B: ''
C:
tasks:
check-set:
desc: Test the task variables
vars:
A_VAR: '{{.A | default "A NOT SET"}}'
B_VAR: '{{.B | default "B NOT SET"}}'
C_VAR: '{{.C | default "C NOT SET"}}'
cmds:
- echo "A is {{.A_VAR}}"
- echo "B is {{.B_VAR}}"
- echo "C is {{.C_VAR}}"produces this output $ task check-set -f -v
task: [/mnt/c/Users/trule] Not found - Using alternative (Taskfile.yml)
task: "check-set" started
task: [check-set] echo "A is fubar"
A is fubar
task: [check-set] echo "B is B NOT SET"
B is B NOT SET
task: [check-set] echo "C is C NOT SET"
C is C NOT SET
task: "check-set" finishedThis PR modifies the requires behaviour to match that of the templating system, which is I think essential for requires to be usable. Currently, we do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and modify the behavior of
requires.Fixes #1676 (discussion #1620)
Modifies/updates #1204
Requires was not working in the case that a variable was set to nil (see discussion/issue).
Additional, the behavior of requires is modified so that an zero length (empty) string value fails the required check. In more complex use cases, with sub-tasks and variable templates, the expectation is that requires will ensure that a variable is set to something. In such cases, an empty string is not considered as something and so the feature is not useful.
An alternative would be to have a way to set a variable value to
nilvia the template mechanism.The change is tested with the following taskfile (modified from the original discussion).